Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pull gateway_mfr build from upstream to reduce build time #76

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

shawaj
Copy link
Member

@shawaj shawaj commented Dec 6, 2021

Issue

How

  • pull gateway_mfr build from upstream
  • update pypi and test-pypi actions
  • add action to check gateway-mfr-rs version weekly and auto-update if necessary
  • remove old unused backup action
  • bumping minor version as this is a fairly substantial change to the build process
  • update README to add more release info and update ROCK Pi hardware info

Screenshots

N/A

References

Closes: #43
Closes: #36
Related to: #20

Draft until upstream PR merged helium/gateway-mfr-rs#10 and gateway-mfr-v0.1.6-arm-unknown-linux-gnueabihf.tar.gz is available

Checklist

  • Tests added
  • Cleaned up commit history (rebase!)
  • Documentation added
  • Thought about variable and method names

@shawaj shawaj force-pushed the shawaj/gatewaymfr branch from 6861a1e to c4d7f9e Compare December 6, 2021 19:57
@shawaj shawaj changed the title feat: pull gateway_mfr build from upstream feat: pull gateway_mfr build from upstream to reduce build time Dec 6, 2021
@shawaj
Copy link
Member Author

shawaj commented Dec 6, 2021

Need to bump version number before merge, and also re-run the testpypi action once the upstream file is available

@shawaj shawaj marked this pull request as ready for review December 6, 2021 23:23
@shawaj shawaj requested a review from a team as a code owner December 6, 2021 23:23
@shawaj shawaj force-pushed the shawaj/gatewaymfr branch 3 times, most recently from 07c4a85 to 16caade Compare December 7, 2021 05:12
- pull gateway_mfr build from upstream
- update pypi and test-pypi actions
- add action to check gateway-mfr-rs version weekly and auto-update if necessary
- remove old unused backup action
- bumping minor version as this is a fairly substantial change to the build process
- update README to add more release info and update ROCK Pi hardware info
- move slack group ID to and environment variable across the whole GitHub org for Nebra Ltd

Closes: #43
Closes: #36
Relates-to: #20
@shawaj shawaj force-pushed the shawaj/gatewaymfr branch from 16caade to a757f93 Compare December 8, 2021 17:28
@sonarcloud
Copy link

sonarcloud bot commented Dec 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shawaj
Copy link
Member Author

shawaj commented Dec 8, 2021

Merging with failing build, because I want to test the update workflow correctly updates to the new v0.1.7 release just pushed today https://github.com/helium/gateway-mfr-rs/releases/tag/v0.1.7

@shawaj shawaj merged commit 51c5b49 into master Dec 8, 2021
@shawaj shawaj deleted the shawaj/gatewaymfr branch December 8, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build gateway-mfr-rs separately document test release artifacts
2 participants