Only prepend $prefix for relative paths #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm seems the installation test is not happy with this change 😿 |
In cases where CMAKE_INSTALL_LIBDIR is already an absolut path adding a $prefix will be incorrect. See also issue on nix pkgs: NixOS/nixpkgs#144170 And current workaround: https://github.com/NixOS/nixpkgs/blob/7eee17a8a5868ecf596bbb8c8beb527253ea8f4d/pkgs/development/libraries/magic-enum/default.nix#L21
fliiiix
force-pushed
the
bugfix/absolut-path-for-pkg-config
branch
from
94febac
to
f042b8e
Compare
|
Not me completely forgetting how bools work and what i want to do 🙈 |
|
Now all looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where CMAKE_INSTALL_LIBDIR is already
an absolute path adding a $prefix will be incorrect.
See also issue on nix pkgs:
NixOS/nixpkgs#144170
And current workaround:
https://github.com/NixOS/nixpkgs/blob/7eee17a8a5868ecf596bbb8c8beb527253ea8f4d/pkgs/development/libraries/magic-enum/default.nix#L21
This should be fully backwards compatible for people that want to have it relocatable.