New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix return type of `zbar_symbol_get_orientation` #151

Open

infacc wants to merge 1 commit into NaturalHistoryMuseum:master from infacc:master

infacc commented Aug 31, 2023

Fixes #139. Implements @simon-staal's proposed solution:

The ZBarOrientation enum class specifies an UNKNOWN type as -1 here. However, when setting zbar_symbol_get_orientation, the c_uint type is passed here. Presumably if this was changed to c_int this would solve this issue?

The original zbar implementation defines zbar_orientation_t as enum with ZBAR_ORIENT_UNKNOWN = -1. Hence, the return type of zbar_symbol_get_orientation is signed.


          fix return type of zbar_symbol_get_orientation

1588a76

purplesword approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet