-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements an ArrowRootAllocationProvider SPI #1040
Open
drewfarris
wants to merge
3
commits into
main
Choose a base branch
from
feature/arrow-root-allocation-provider
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
src/main/java/emissary/spi/ArrowRootAllocatorProvider.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
package emissary.spi; | ||
|
||
import org.apache.arrow.memory.BufferAllocator; | ||
import org.apache.arrow.memory.RootAllocator; | ||
|
||
public class ArrowRootAllocatorProvider implements InitializationProvider { | ||
|
||
private static final Object initalizationLock = new Object(); | ||
private static BufferAllocator arrowRootAllocator = null; | ||
|
||
@Override | ||
public void initialize() { | ||
synchronized (initalizationLock) { | ||
arrowRootAllocator = new RootAllocator(); | ||
} | ||
} | ||
|
||
@Override | ||
public void shutdown() { | ||
synchronized (initalizationLock) { | ||
arrowRootAllocator.close(); | ||
arrowRootAllocator = null; | ||
} | ||
InitializationProvider.super.shutdown(); | ||
} | ||
|
||
public static BufferAllocator getArrowRootAllocator() { | ||
synchronized (initalizationLock) { | ||
if (arrowRootAllocator == null) { | ||
throw new IllegalStateException("Arrow Root Allocator has not been initalized by the " + | ||
"ArrowRootAllocatorProvider or is already shutdown, is emissary.spi.ArrowRootAllocatorProver " + | ||
"listed in META-INF/services/emissary.spi.InitalizationProvider?"); | ||
} else { | ||
return arrowRootAllocator; | ||
} | ||
} | ||
} | ||
} |
1 change: 1 addition & 0 deletions
1
src/main/resources/META-INF/services/emissary.spi.InitializationProvider
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
emissary.spi.JavaCharSetInitializationProvider | ||
emissary.spi.ClassLocationVerificationProvider | ||
emissary.spi.ArrowRootAllocatorProvider |
30 changes: 30 additions & 0 deletions
30
src/test/java/emissary/spi/ArrowRootAllocatorProviderTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
package emissary.spi; | ||
|
||
import emissary.test.core.junit5.UnitTest; | ||
|
||
import org.apache.arrow.memory.BufferAllocator; | ||
import org.junit.jupiter.api.Test; | ||
|
||
import static org.junit.jupiter.api.Assertions.assertNotNull; | ||
import static org.junit.jupiter.api.Assertions.assertThrows; | ||
|
||
public class ArrowRootAllocatorProviderTest extends UnitTest { | ||
@Test | ||
public void testArrowRootAllocatorProvider() { | ||
ArrowRootAllocatorProvider provider = new ArrowRootAllocatorProvider(); | ||
provider.initialize(); | ||
BufferAllocator allocator = ArrowRootAllocatorProvider.getArrowRootAllocator(); | ||
assertNotNull(allocator); | ||
} | ||
|
||
@Test() | ||
public void testArrowRootAllocatorProviderAfterShutdown() { | ||
ArrowRootAllocatorProvider provider = new ArrowRootAllocatorProvider(); | ||
provider.initialize(); | ||
BufferAllocator allocatorOne = ArrowRootAllocatorProvider.getArrowRootAllocator(); | ||
assertNotNull(allocatorOne); | ||
provider.shutdown(); | ||
assertThrows(IllegalStateException.class, ArrowRootAllocatorProvider::getArrowRootAllocator, "expected IllegalStateException"); | ||
} | ||
} | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not totally certain this is the best way to approach this, but it's a good point for discussion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is marked outdated because I moved the exclusion to the
dependencyManagement
section, but it's still relevant to discuss.