Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use favicon from admin client #23

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Use favicon from admin client #23

merged 1 commit into from
Mar 12, 2024

Conversation

attemoi
Copy link
Contributor

@attemoi attemoi commented Mar 12, 2024

Description

Use favicon from admin client.

Motivation and Context

https://jira.lingsoft.fi/browse/SIMPLYE-229 - Internal server error for admin favicon.ico

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@attemoi attemoi requested a review from ttuovinen March 12, 2024 09:08
@attemoi attemoi marked this pull request as ready for review March 12, 2024 10:26
attemoi
attemoi commented Mar 12, 2024
View reviewed changes
Copy link
Contributor Author

@attemoi attemoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New admin release created, good to go.

api/admin/config.py Show resolved Hide resolved
@attemoi attemoi merged commit 9bb2479 into main Mar 12, 2024
19 checks passed
@attemoi attemoi deleted the bugfix/simplye-229/favicon branch March 12, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuovinen ttuovinen ttuovinen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@attemoi @ttuovinen