Ekirjasto 132 fix import fail with empty string #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Covers both empty strings and null values
NatLibFi-JoonaKupe
approved these changes
Nov 21, 2024
natlibfi-kaisa
deleted the
EKIRJASTO-132-Fix-import-fail-with-empty-string
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables importing books with missing contruibutor name information.
Motivation and Context
Just recently handles a similar case where contributor name was
null. Now the code also handles cases where the value is an empty string.How Has This Been Tested?
Unit tests.
Checklist