EKIR-389 Classify poetry as fiction #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Classify Poetry as Fiction.
Motivation and Context
Poetry was classified as None. These changes classify Poetry as fiction except if it's a subclass of something non-fiction. Note though, that our test feed does not have any book with a BISAC code where Poetry is a subclass of a non-fiction book so this behaviour can only be observed in unit tests.
How Has This Been Tested?
Unit testing and local backend testing (run opds_import_monitor, check results in opensearch dashoard).
Checklist