Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement vocab home using Bootstrap Grid instead of tables #1697

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

osma
Copy link
Member

@osma osma commented Oct 9, 2024

Reasons for creating this PR

The vocabulary home page looks ugly and is using twig template structures copied from Skosmos 2, for example HTML tables. This PR reimplements the main part and the download links using Bootstrap Grid, similar to the concept page.

Also contains a minor fix to the concept page. The template code is now aligned between these two so that partial page loads work better.

Link to relevant issue(s), if any

Description of the changes in this PR

  • reimplement vocab info twig template using Bootstrap Grid (+ corresponding CSS changes)
  • align concept and vocab home template structure

Known problems or uncertainties in this PR

  • property-specific Cypress tests needed; but these are difficult to do because of the simplistic way that the backend provides vocab info properties as a key-value lists

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma self-assigned this Oct 9, 2024
Copy link

sonarcloud bot commented Oct 10, 2024

@osma osma added this to the 3.0 milestone Oct 10, 2024
@osma osma marked this pull request as ready for review October 10, 2024 10:23
@osma osma requested a review from miguelvaara October 10, 2024 10:23
@osma osma changed the title WIP: Reimplement vocab home using Bootstrap Grid instead of tables Reimplement vocab home using Bootstrap Grid instead of tables Oct 10, 2024
Copy link
Contributor

@joelit joelit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I unchecked one box from the corresponding issue, since the PR didn't implement the feature (show title only once, even if it is present twice).

Screenshot from 2024-10-10 15-22-42

@osma osma merged commit aeb3ed5 into main Oct 10, 2024
10 checks passed
@osma osma deleted the issue1482-vocab-home-grid branch October 10, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR)
Development

Successfully merging this pull request may close these issues.

2 participants