Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for scoping vocabularies by skos:inScheme. #1236

Open
wants to merge 2 commits into
base: skosmos-2
Choose a base branch
from

Conversation

pulquero
Copy link

@pulquero pulquero commented Nov 9, 2021

New vocabulary config property skosmos:conceptSchemes to optional scope queries using skos:inScheme. This is an alternative to using GRAPHs or different endpoints, particularly when dealing with highly interconnected vocabularies.

@pulquero pulquero force-pushed the inscheme branch 3 times, most recently from a44e088 to 36a7511 Compare November 9, 2021 15:15
Copy link
Collaborator

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a quick look, but not reviewing it 👍 one minor comment that caught my eye. Great work @pulquero!

model/Model.php Outdated
}

/**
* Returns a SPARQL endpoint object using the default implementation set in the config.ttl.
*/
public function getDefaultSparql()
{
return $this->getSparqlImplementation($this->getConfig()->getDefaultSparqlDialect(), $this->getConfig()->getDefaultEndpoint(), '?graph');
$graph = !$this->getConfig()->getDefaultGraphOnly() ? '?graph' : null;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong indentation ☝️

@sonarcloud
Copy link

sonarcloud bot commented Nov 11, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants