-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Optimize bash scripts for install #377
base: naomi-dev
Are you sure you want to change the base?
feat: Optimize bash scripts for install #377
Conversation
Here are my findings so far but cant go further until the phonetisaurus issue is resolved.
|
The phonetisaurus thing is new. I was able to install with a simple pip install phonetisaurus on my last copy of Raspberry Pi OS just a couple of weeks ago. I am running this on the latest copy of Raspberry Pi OS (released Feb 2023) but the version of python is still 3.9.2. I was able to download the phonetisaurus wheel file from https://github.com/rhasspy/phonetisaurus-pypi/releases/download/v0.3.0/phonetisaurus-0.3.0-py3-none-linux_aarch64.whl but doing that means we will have to be able to detect whether we are running on a an x86_64, arm7l, or aarch64. |
Actually, there is no reason to install either phonetisaurus or pocketsphinx from pip, since we are building and installing python-pocketsphinx from source and installing phonetisaurus from source and not using the python wrapper, so I'll just remove those for now. |
I think it makes sense to keep the question about running uninterrupted should stay with the processing at the top of the setup_wizard() function. I'm not sure what the top two sections of the WizardSetup() function do. The first one just seems to be an introduction which tells you that you are in the "deb" installer and that it will help setup Naomi, the second just says "Let's examine your security settings" which I think used to check if you were using the pi/raspberry username/password but now just does another sleep. In my edits, I have put the call to WizardSetup() right at the beginning of setup_wizard() and just moved the question about running uninterrupted out of that section. |
I get the error message "ImportError: Pocketsphinx not installed!" so it looks like the |
This contains some suggested fixes from my first attempt at using this updated install script. Problems that still remain include 1) Phonetisaurus and the Pocketsphinx python package not being installed 2) the naomi-setup.sh script importing external files that would not be available if the user is using the one-liner
Fixes from first install attempt
Optimize the bash scripts for the installer to avoid repeating code in multiple places.
Description
Optimizing the bash installer scripts to reduce code footprint, as some of the functions
within the files can be re-used in several places. This PR has migrated some of the commonly
used functions and values into specific files. That can be called when needed, this will allow
flexibility when porting to other linux based distros.
Related Issue
Motivation and Context
How Has This Been Tested?
The code has been tested on docker containers with the following environments:
Screenshots (if appropriate):
Types of changes
Checklist: