Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Quality minor Refactor #392

Merged
merged 2 commits into from
May 29, 2024
Merged

Data Quality minor Refactor #392

merged 2 commits into from
May 29, 2024

Conversation

nikml
Copy link
Contributor

@nikml nikml commented May 29, 2024

No description provided.

@nikml nikml requested a review from nnansters as a code owner May 29, 2024 18:00
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 76.76%. Comparing base (022b8fa) to head (236421e).

Files Patch % Lines
nannyml/distribution/categorical/calculator.py 0.00% 1 Missing ⚠️
nannyml/distribution/continuous/calculator.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
+ Coverage   76.73%   76.76%   +0.02%     
==========================================
  Files         109      108       -1     
  Lines        9250     9248       -2     
  Branches     1658     1656       -2     
==========================================
+ Hits         7098     7099       +1     
+ Misses       1686     1685       -1     
+ Partials      466      464       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nnansters nnansters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, cheers!

@nnansters nnansters merged commit b8b237f into main May 29, 2024
7 of 8 checks passed
@nnansters nnansters deleted the upd_dq branch May 29, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants