Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for np.array in the common_nan_removal function #388

Merged
merged 4 commits into from
May 16, 2024

Conversation

nnansters
Copy link
Contributor

This PR introduces the option to call the common_nan_removal function with a list of numpy arrays. When doing so you must provide the a list of integer indices for the selected_columns argument.

The existing functionality has been put into a private helper function. Then I added a function to deal with the np.array input. The existing common_nan_removal function has been turned into a wrapper for both helpers, along with some overloaded definitions for easier typing.

Also added some tests

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 70.37037% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 76.52%. Comparing base (9a1760f) to head (107913f).

Files Patch % Lines
nannyml/base.py 70.37% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
- Coverage   76.53%   76.52%   -0.02%     
==========================================
  Files         110      110              
  Lines        9221     9242      +21     
  Branches     1650     1658       +8     
==========================================
+ Hits         7057     7072      +15     
- Misses       1699     1703       +4     
- Partials      465      467       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nnansters nnansters marked this pull request as ready for review May 15, 2024 17:01
@nnansters nnansters requested a review from nikml as a code owner May 15, 2024 17:01
@nnansters nnansters force-pushed the feature/extended-common-nan-support branch from 13c9115 to 558b5d7 Compare May 16, 2024 09:30
@nnansters nnansters merged commit 27b713d into main May 16, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant