Update analytics for compatibility with cloud SDK #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `analytics-python` package currently used has a dependency on backoff `==1.10.0`. This conflicts with the NannyML Cloud SDK which has a dependency on backoff `>=1.11.1,<3.0` (because of its `gql` dependency). This commit fixes that by updating the analytics package to the latest version. It was renamed to `segment-analytics-python` but still performs the same package as the original `analytics-python`.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #376 +/- ##
=======================================
Coverage 78.44% 78.44%
=======================================
Files 110 110
Lines 8514 8514
Branches 1514 1514
=======================================
Hits 6679 6679
Misses 1472 1472
Partials 363 363 ☔ View full report in Codecov by Sentry. |
nnansters
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
analytics-pythonpackage currently used has a dependency on backoff==1.10.0. This conflicts with the NannyML Cloud SDK which has a dependency on backoff>=1.11.1,<3.0(because of itsgqldependency).This commit fixes that by updating the analytics package to the latest version. It was renamed to
segment-analytics-pythonbut still performs the same package as the originalanalytics-python.