Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyarrow with conditions on pythons versions #372

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

amrit110
Copy link
Contributor

@amrit110 amrit110 commented Feb 29, 2024

Update pyarrow dependency. Since nannyml has python 3.7 support, the dependency version is conditional.

For 3.7 -> pyarrow version 12.0.0 and above but less than 13.0.0
For 3.8 - 3.12 -> pyarrow version 14.0.0 and above but less than 15.0.0

Addresses #365

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.99%. Comparing base (be87811) to head (ebedf02).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #372   +/-   ##
=======================================
  Coverage   78.99%   78.99%           
=======================================
  Files         110      110           
  Lines        8273     8273           
  Branches     1494     1494           
=======================================
  Hits         6535     6535           
  Misses       1390     1390           
  Partials      348      348           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nnansters
Copy link
Contributor

Great stuff @amrit110 , thanks for your contribution! I'll make a new release for you soon. For now you can install straight from Git!

@nnansters nnansters merged commit bfdd76b into NannyML:main Feb 29, 2024
7 checks passed
@amrit110
Copy link
Contributor Author

thanks a lot @nnansters!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants