Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove expired links in Dublin LiDAR record alert #377

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

nmwolf
Copy link
Collaborator

@nmwolf nmwolf commented Sep 20, 2024

Problem

Alert message on Dublin LiDAR records have expired links and surveys that are no longer active

Solution

Remove expired links and maintain the reference to the YouTube flyover video and the DOI.

Type

chore

@nmwolf nmwolf requested review from ekate and spilth September 20, 2024 13:50
@spilth
Copy link
Collaborator

spilth commented Sep 20, 2024

@nmwolf It looks like this text has a spec associated with it that needs to be updated:

Failures:

  1) Show page with suppressed download - nyu-2451-38684 includes survey link
     Failure/Error:
       expect(page).to have_link(
         'this brief survey', href: 'https://nyu.qualtrics.com/jfe/form/SV_42ddIXjT0CtaqAR'
       )

       expected to find link "this brief survey" with href "https://nyu.qualtrics.com/jfe/form/SV_42ddIXjT0CtaqAR" but there were no matches
     # ./spec/features/show_page_spec.rb:51:in `block (3 levels) in <top (required)>'

@nmwolf nmwolf force-pushed the 376-lidar-message-update branch from 5d06552 to 5058af0 Compare September 25, 2024 14:12
@nmwolf nmwolf merged commit 2ebc87c into main Sep 25, 2024
1 check passed
@nmwolf nmwolf deleted the 376-lidar-message-update branch September 25, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants