Open restricted downloads in new tab to avoid blank page #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This set up looks like a good working solution from the user point of view. |
nmwolf
approved these changes
Aug 5, 2024
mnyrop
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a user attempts to download a restricted "Original Shapefile" for the first time while not being logged in, they are left on a blank page at the end of the sign-in/download process.
Solution
Force restricted "Original Shapefile" downloads to open in a new tab so they still have an SDR tab open at the end of the process. Future downloads (while now logged in) will open and close a new tab automatically, leaving you right where you were.
Additionally, I migrated the "Downloads Collapse" partial to a View Component to allow for easier view testing.
Addresses #312
Type
Bug Fix
Video
First download is an unrestricted file, second download is a restricted file.
Screen.Recording.2024-08-01.at.12.54.31.PM.mov