Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Search History for ZoLa #13

Closed
wants to merge 1 commit into from

Conversation

dhochbaum-dcp
Copy link

@dhochbaum-dcp dhochbaum-dcp commented Apr 9, 2024

This, along with #1199, completes #1191

@TylerMatteo
Copy link

TylerMatteo commented Apr 9, 2024

@dhochbaum-dcp In the interest of maintaining this code as reusable components not coupled to any particular app, I'd really like to avoid having a Zola-specific component. Is there anything about how Zola uses the component that would cause the new functionality to break in other apps? And even if that is the case, we can make these changes to the existing labs-search component, release a new version of the addon to npm, and only update Zola to that version.

@dhochbaum-dcp
Copy link
Author

@dhochbaum-dcp In the interest of maintaining this code as reusable components not coupled to any particular app, I'd really like to avoid having a Zola-specific component. Is there anything about how Zola uses the component that would cause the new functionality to break in other apps? And even if that is the case, we can make these changes to the existing labs-search component, release a new version of the addon to npm, and only update Zola to that version.

I don't think there's inherently anything that would break in other apps, but I don't know which of our other apps it's used in, and whether we'd want to have Search History automatically enabled in them. It's also open source, so who knows who else is using it...what I'm going to do is close this PR, and open a new PR which makes the changes to the existing labs-search component, with Search History functionality turned off by default. Then I'll open a new PR for ZoLa which uses the labs-search component with @useSearchHistory={{true}} added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants