Upgrade to Ember 4.12 and Node 18 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerMatteo
force-pushed
the
task/13775-ember4-node18-upgrade
branch
from
7524c2a to
ca01d5b
Compare
TangoYankee
reviewed
Jul 26, 2023
| push: | ||
| branches: | ||
| - main | ||
| - master |
There was a problem hiding this comment.
Do we have a master branch in this repo? I couldn't find one. If not, could we get rid of this reference?
TangoYankee
reviewed
Jul 26, 2023
|
@TylerMatteo Most of our applications will still rely on v2 of ose-ember-addons. Should we take this opportunity to split v2 into its own long-lived branch that we can use for updates, independent of the v3 code that will take over main? |
TangoYankee
reviewed
Jul 26, 2023
TangoYankee
reviewed
Jul 26, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
TangoYankee
reviewed
Aug 2, 2023
Co-authored-by: Timothy Miller <[email protected]>
…remove ember-cli-addon-docs
…tests from ember upgrades
…eton layer groups
TylerMatteo
force-pushed
the
task/13775-ember4-node18-upgrade
branch
from
b5d8df0 to
b2a9c83
Compare
| @@ -35,28 +35,37 @@ export default Component.extend({ | |||
|
|
|||
| actions: { | |||
There was a problem hiding this comment.
We should refactor labs-bbl-lookup away from the actions hash.
Co-authored-by: Matt Gardner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates this package to use Ember 4.12 and Node 18. Most of the changes seen below are a result of running
ember-cli-update --to 4.12. Changes done "by hand" include:nyc-planning-style-guidedependency to a version with the changes in this PR./for doing division in SASSRemoveTurns out this code was required for "singleton" type layer groups. The only case of this I've found are the "aerial" layers. I originally removed the code to get past an error I was seeing concerning an apparent infinite state update loop. Removing this code fixed that error but broke the aerials by causing all of those layers to turn on together instead of only one at a time. I resolved this by putting the code back but only setting_firstOccurringLayerfrom layerGroup model. It was causing errors after making some other changes and, as far as I can tell, it's not used anywhere._firstOccurringLayerfor singleton type layer groups.yarn. These warnings weren't causing issues because the packages needed happened to be provided by transient deps in our packages but resolving them ensures we don't inadvertently break the addon by uninstalling unrelated packages.largestMinZoomcomputed property to the layer-group model. This will be used downstream in Zola to keep some functionality that I had to refactor for Zola's upgrades.ember-cli-updatecouldn't automate - mainly addingthis.in templates that were doing implicitythis.I've already tested my Zola branch with a pre-release version made from this branch and things seem to be working as expected. Once this is approved and merged, I'll version it to 3.0.0 and publish that.