Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1611 Build endpoint to re-send confirmation email #1621

Merged
merged 1 commit into from
Dec 11, 2024
Merged

1611 Build endpoint to re-send confirmation email #1621

merged 1 commit into from
Dec 11, 2024

Conversation

dhochbaum-dcp
Copy link
Collaborator

Summary

Adds the /subscribers/:email/resend-confirmation endpoint.

Tasks/Bug Numbers

Technical Explanation

Any other info you think would help a reviewer understand this PR?

@dhochbaum-dcp dhochbaum-dcp requested a review from a team as a code owner December 10, 2024 22:08
@netlify Netlify
Copy link

netlify bot commented Dec 10, 2024 •
edited
Loading

✅ Deploy Preview for labs-zap ready!

Name Link
🔨 Latest commit 345d135
🔍 Latest deploy log https://app.netlify.com/sites/labs-zap/deploys/6758bbe97b05f00008503f73
😎 Deploy Preview https://deploy-preview-1621--labs-zap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dhochbaum-dcp dhochbaum-dcp mentioned this pull request Dec 10, 2024
Merged
@dhochbaum-dcp dhochbaum-dcp changed the title Build endpoint to re-send confirmation email 1611 Build endpoint to re-send confirmation email Dec 10, 2024
pratishta
pratishta approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@pratishta pratishta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Only nit is considering making existingUser['1'].result[params.email].contact.custom_fields easier to read since we use it twice

@dhochbaum-dcp dhochbaum-dcp merged commit 48b343a into develop Dec 11, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pratishta pratishta pratishta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build endpoint to re-send confirmation email
2 participants
@dhochbaum-dcp @pratishta