1550 confirm patch endpoint #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for labs-zap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pratishta
force-pushed
the
1550-confirm-patch-endpoint
branch
from
d9353fb to
6648544
Compare
TylerMatteo
requested changes
Nov 8, 2024
| * @returns {object} | ||
| */ | ||
| async update(environment: string, email: string, custom_fields: object) { | ||
| var updated_custom_fields = Object.entries(custom_fields).reduce((acc, curr) => ({ ...acc, [`zap_${environment}_${curr[0]}`]: curr[1] }), {}) |
There was a problem hiding this comment.
Can we stick with let or const and camelCased variable/parameter names?
There was a problem hiding this comment.
Do you want me to update to let and camelCase for the create in here as well ?
TylerMatteo
approved these changes
Nov 12, 2024
Co-authored-by: David Hochbaum <[email protected]>
TylerMatteo
force-pushed
the
1550-confirm-patch-endpoint
branch
from
cd64fbb to
f9755a1
Compare
TylerMatteo
approved these changes
Nov 12, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1550
I tested it with the following request body in Postman:
and with a
zap_staging_idpulled from Sendgrid contacts.