Pratishta/subscribe #1563
Merged
Pratishta/subscribe #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for labs-zap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pratishta
force-pushed
the
pratishta/subscribe
branch
2 times, most recently
from
3565742 to
4b3b6e6
Compare
| if (district.boro == 'Brooklyn') { | ||
| this.subs['brooklyn'].push({ ...district, 'checked': 0 }); | ||
| const districts = lookupCommunityDistrict(); | ||
| for (const district of districts) { |
There was a problem hiding this comment.
It would be more in line with previous usage and more performant if you put this in the helper.
dhochbaum-dcp
approved these changes
Nov 15, 2024
TylerMatteo
force-pushed
the
pratishta/subscribe
branch
from
b209317 to
f4bb249
Compare
TylerMatteo
force-pushed
the
pratishta/subscribe
branch
from
f4bb249 to
dbfe071
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1542