1605 upgrade to node 20, fixed one test failure

NYCPlanning · Dec 9, 2024 · 911e19c · 911e19c
1 parent e2303fa
commit 911e19c
Show file tree

Hide file tree

Showing 4 changed files with 1,876 additions and 2,339 deletions.
diff --git a/server/.nvmrc b/server/.nvmrc
@@ -1 +1 @@
-18.19.0
+20
diff --git a/server/package.json b/server/package.json
@@ -5,7 +5,7 @@
   "author": "",
   "license": "MIT",
   "engines": {
-    "node": "18"
+    "node": "20"
   },
   "scripts": {
     "build": "rimraf dist && tsc -p tsconfig.build.json",

diff --git a/server/src/disposition/defaultValue.disposition.pipe.ts b/server/src/disposition/defaultValue.disposition.pipe.ts
@@ -3,12 +3,23 @@ import { PipeTransform, Injectable, ArgumentMetadata } from "@nestjs/common";
 @Injectable()
 export class defaultValueDispositionPipe implements PipeTransform<any, any> {
   transform(value: any, { type }: ArgumentMetadata) {
-    const { data } = value;
-    if (type === "body") {
-      if (!data.attributes["dcp-nameofpersoncompletingthisform"]) {
-        data.attributes["dcp-nameofpersoncompletingthisform"] =
-          "ZAP LUP Portal";
+    const data = value?.data;
+
+    if (!data) {
+      console.debug('Value is empty or does not contain "data". Skipping processing.');
+      return value;
+    }
+
+    try {
+      if (type === "body") {
+        if (!data.attributes["dcp-nameofpersoncompletingthisform"]) {
+          data.attributes["dcp-nameofpersoncompletingthisform"] =
+            "ZAP LUP Portal";
+        }
       }
+    } catch (e) {
+      console.debug(`Error setting default value for disposition: ${e.message}`);
+      return value = null;
     }
     return value;
   }