Remove 'Unknown' project type filter

NYCPlanning · Apr 29, 2024 · 8e24b5a · 8e24b5a
1 parent cd38e95
commit 8e24b5a
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 5 deletions.
diff --git a/client/app/templates/components/project-list-item.hbs b/client/app/templates/components/project-list-item.hbs
@@ -9,7 +9,6 @@
         </span>
       </a>
     {{/if}}
-    <span class="label publicstatus-label">{{unless (eq project.dcpPublicstatusSimp 'Unknown') project.dcpPublicstatusSimp "Unknown Status"}}</span>
   </div>
   <div class="cell auto">
     {{#if project.dcpLastmilestonedate}}

diff --git a/client/app/templates/show-geography.hbs b/client/app/templates/show-geography.hbs
@@ -106,7 +106,7 @@
           filterTitle=(get-label-for 'filters.dcp_publicstatus')
           tooltip='These checkboxes filter projects by their stage in the application process. "Noticed" refers to applications where notice has been given that an application will certify no sooner than 30 days per the City Charter requirement. In "Public Review” refers to applications that have graduated to the public review process. “Completed” refers to applications that have been Approved, Disapproved, Withdrawn or Terminated.'}}
           <ul class="menu vertical medium-horizontal stage-checkboxes">
-            {{#each (array 'Filed' 'Noticed' 'In Public Review' 'Completed' 'Unknown') as |type|}}
+            {{#each (array 'Filed' 'Noticed' 'In Public Review' 'Completed') as |type|}}
               <li {{action section.delegate-mutation (action 'mutateArray' 'dcp_publicstatus' type)}}
                 data-test-status-checkbox={{type}}
               >

diff --git a/client/mirage/factories/project.js b/client/mirage/factories/project.js
@@ -16,7 +16,7 @@ export default Factory.extend({
   // Domain is ['Noticed', Filed', 'In Public Review', 'Completed']
   dcpPublicstatus: 'Filed',
 
-  // Domain is ['Noticed', 'Filed', 'In Public Review', 'Completed', 'Unknown']
+  // Domain is ['Noticed', 'Filed', 'In Public Review', 'Completed']
   // This field is derived from dcpPublicstatus.
   // See https://github.com/NYCPlanning/zap-api/blob/develop/queries/projects/show.sql#L28
   dcpPublicstatusSimp: 'Filed',

diff --git a/server/src/project/project.service.ts b/server/src/project/project.service.ts
@@ -58,8 +58,7 @@ export const PROJECT_STATUS_LOOKUP = {
   Noticed: 717170005,
   Filed: 717170000,
   "In Public Review": 717170001,
-  Completed: 717170002,
-  Unknown: null
+  Completed: 717170002
 };
 export const PROJECT_VISIBILITY_LOOKUP = {
   "Applicant Only": 717170002,
-Original file line number
+Diff line change
@@ Expand Up / @@ -9,7 +9,6 @@ @@
             </span>
           </a>
         {{/if}}
-        <span class="label publicstatus-label">{{unless (eq project.dcpPublicstatusSimp 'Unknown') project.dcpPublicstatusSimp "Unknown Status"}}</span>
       </div>
       <div class="cell auto">
         {{#if project.dcpLastmilestonedate}}
@@ Expand Down @@