update prod and qa secrets to vars

NYCPlanning · Sep 11, 2024 · 19e4442 · 19e4442
1 parent a67c2be
commit 19e4442
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 14 deletions.
diff --git a/.github/workflows/production-client.yml b/.github/workflows/production-client.yml
@@ -10,11 +10,11 @@ jobs:
       url: https://zap.planninglabs.nyc
     runs-on: ubuntu-latest
     env:
-      HOST: ${{secrets.ZAP_API_HOST}}
-      NYCID_CLIENT_ID: ${{secrets.NYCID_CLIENT_ID}}
-      NYC_ID_HOST: ${{secrets.NYC_ID_HOST}}
-      MAINTENANCE_START: ${{secrets.MAINTENANCE_START}}
-      MAINTENANCE_END: ${{secrets.MAINTENANCE_END}}
+      HOST: ${{ vars.ZAP_API_HOST }}
+      NYCID_CLIENT_ID: ${{ vars.NYCID_CLIENT_ID }}
+      NYC_ID_HOST: ${{ vars.NYC_ID_HOST }}
+      MAINTENANCE_START: ${{ vars.MAINTENANCE_START }}
+      MAINTENANCE_END: ${{ vars.MAINTENANCE_END }}
     steps:
       - uses: actions/checkout@v4
         with:

diff --git a/.github/workflows/production-server.yml b/.github/workflows/production-server.yml
@@ -18,7 +18,7 @@ jobs:
         with:
           heroku_email: ${{secrets.HEROKU_EMAIL}}
           heroku_api_key: ${{secrets.HEROKU_API_KEY}}
-          heroku_app_name: $${{secrets.HEROKU_APP_NAME}}
+          heroku_app_name: ${{ vars.HEROKU_APP_NAME }}
           team: ${{secrets.HEROKU_TEAM}}
           appdir: server
         env:
@@ -34,8 +34,8 @@ jobs:
           HD_GITHUB_ACCESS_TOKEN: ${{secrets.FEEDBACK_GITHUB_ACCESS_TOKEN}}
           HD_NEW_RELIC_LICENSE_KEY: ${{ secrets.NEW_RELIC_LICENSE_KEY }}
           HD_NEW_RELIC_LOG: ${{ secrets.NEW_RELIC_LOG }}
-          HD_NODE_ENV: ${{ secrets.NODE_ENV }}
-          HD_NPM_CONFIG_PRODUCTION: ${{ secrets.NPM_CONFIG_PRODUCTION }}
+          HD_NODE_ENV: ${{ vars.NODE_ENV }}
+          HD_NPM_CONFIG_PRODUCTION: ${{ vars.NPM_CONFIG_PRODUCTION }}
           HD_NYCID_CONSOLE_PASSWORD: ${{secrets.NYCID_CONSOLE_PASSWORD}}
           HD_PAPERTRAIL_API_TOKEN: ${{ secrets.PAPERTRAIL_API_TOKEN }}
           HD_RECAPTCHA_SECRET_KEY: ${{secrets.RECAPTCHA_SECRET_KEY}}

diff --git a/.github/workflows/qa.yml b/.github/workflows/qa.yml
@@ -18,7 +18,7 @@ jobs:
         with:
           heroku_email: ${{secrets.HEROKU_EMAIL}}
           heroku_api_key: ${{secrets.HEROKU_API_KEY}}
-          heroku_app_name: ${{secrets.HEROKU_APP_NAME}}
+          heroku_app_name: ${{ vars.HEROKU_APP_NAME }}
           team: ${{secrets.HEROKU_TEAM}}
           appdir: server
         env:
@@ -50,11 +50,11 @@ jobs:
       url: https://staging--labs-zap.netlify.app
     runs-on: ubuntu-latest
     env:
-      HOST: ${{secrets.ZAP_API_HOST}}
-      NYCID_CLIENT_ID: ${{secrets.NYCID_CLIENT_ID}}
-      NYC_ID_HOST: ${{secrets.NYC_ID_HOST}}
-      MAINTENANCE_START: ${{secrets.MAINTENANCE_START}}
-      MAINTENANCE_END: ${{secrets.MAINTENANCE_END}}
+      HOST: ${{ vars.ZAP_API_HOST }}
+      NYCID_CLIENT_ID: ${{ vars.NYCID_CLIENT_ID }}
+      NYC_ID_HOST: ${{ vars.NYC_ID_HOST }}
+      MAINTENANCE_START: ${{ vars.MAINTENANCE_START }}
+      MAINTENANCE_END: ${{ vars.MAINTENANCE_END }}
     steps:
       - uses: actions/checkout@v4
         with: