Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

289 Search results now include CDTAs #291

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

dhochbaum-dcp
Copy link
Contributor

@dhochbaum-dcp dhochbaum-dcp commented Mar 25, 2024

Summary

Fixes an issue where when searching for a CDTA, the search and map does not yield a result.

Tasks/Bug Numbers

image

@dhochbaum-dcp dhochbaum-dcp changed the title Search results now include CDTAs 289 Search results now include CDTAs Mar 25, 2024
@dhochbaum-dcp dhochbaum-dcp marked this pull request as ready for review March 25, 2024 17:04
@dhochbaum-dcp dhochbaum-dcp requested a review from a team as a code owner March 25, 2024 17:04
OR boroname LIKE '%25${string}%25'
OR geolabel LIKE '%25${string}%25'
cdta2020 ILIKE '%25${string}%25'
OR geolabel ILIKE '%25${string}%25'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still have access to the fips and boroname information in the feature.properties on line 33?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we are still returning those fields (lines 11 and 21); we are just not searching within them for the queried string.

@dhochbaum-dcp dhochbaum-dcp merged commit 34d0c47 into develop Mar 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants