-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cdbg data product #1355
add cdbg data product #1355
Conversation
98167a6
to
812820b
Compare
9d34b8b
to
600d11b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1355 +/- ##
==========================================
+ Coverage 70.07% 70.36% +0.29%
==========================================
Files 115 114 -1
Lines 6145 5966 -179
Branches 706 693 -13
==========================================
- Hits 4306 4198 -108
+ Misses 1692 1622 -70
+ Partials 147 146 -1 ☔ View full report in Codecov by Sentry. |
Just noting that some block groups have 0 population - for these, should percentages be 0 (as reported in the source data) or null? |
when I hit "divide by 0" issues, I went with 0 as the result for now since I didn't wanna have to handle nulls yet this made the final eligibility queries simpler and allows a but I could see why we might wanna use nulls to be less misleading |
related to #1348