Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _v2 from metadata #1354

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Remove _v2 from metadata #1354

merged 2 commits into from
Dec 31, 2024

Conversation

alexrichey
Copy link
Contributor

@alexrichey alexrichey commented Dec 30, 2024

_v2 gets the ✂️

Commit 1 is mostly automated. Hopefully there's nothing to see there.

Commit 2 is a straggling update of the ESRI connector to use the new metadata format. We barely use this, so I'm not terribly concerned about the details.

@alexrichey alexrichey changed the base branch from ar-socrata-bytes-gha to main December 30, 2024 21:46
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 97.10145% with 6 lines in your changes missing coverage. Please review.

Project coverage is 70.36%. Comparing base (89f8722) to head (99fffa6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dcpy/models/product/dataset/metadata.py 97.43% 4 Missing and 1 partial ⚠️
dcpy/connectors/esri/arcgis_feature_service.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1354      +/-   ##
==========================================
+ Coverage   69.98%   70.36%   +0.38%     
==========================================
  Files         115      114       -1     
  Lines        6147     5966     -181     
  Branches      706      693      -13     
==========================================
- Hits         4302     4198     -104     
+ Misses       1699     1622      -77     
  Partials      146      146              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexrichey alexrichey force-pushed the ar-metadata-cleanup branch 3 times, most recently from 10db362 to 8550871 Compare December 31, 2024 18:18
@alexrichey alexrichey merged commit 47f2592 into main Dec 31, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants