-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create admin folder #1143
create admin folder #1143
Conversation
70c87a9
to
45aa87e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1143 +/- ##
==========================================
+ Coverage 66.25% 66.76% +0.50%
==========================================
Files 106 105 -1
Lines 5372 5331 -41
Branches 799 791 -8
==========================================
Hits 3559 3559
+ Misses 1686 1645 -41
Partials 127 127 ☔ View full report in Codecov by Sentry. |
644b684
to
53b6833
Compare
53b6833
to
bd99ea2
Compare
may I suggest a small readme file or updated wiki page to have a short description of ops and run environment folders? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to keep it in bash
? Sorry if I missed this being discussed during the meeting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we decided on the couple things left in this folder. They're all sort of "build utils" or something along those lines - this one maybe a little more in-between given that it's a final setup that runs before a build.
I think we just leave them for now
If this gets merged I'll update https://github.com/NYCPlanning/data-engineering/wiki/Repository-Structure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels like a definite improvement!
Updated both repository structure and docker image management wiki pages |
ty! |
Bunch of little things
docker
andpython
folders moved intoadmin/run_environment
python
folder removed (reqs and constraints moved up intorun_environment
docker
publish scripts tweaked to run from root of projectops
folder created withinadmin
- scripts that are run for specific operations. Some of these are run frequently - compile python requirements, clean build artifacts, etc. Some won't be -> create/setup dev bucketSome of the commits are useful, mainly for specific code changes, but more than anything I would just look at the repo checked out to this branch and see what you think.
docker publish job working
compile python packages job working (and pr created)
clean build artifacts job working
qa deploy working