Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create admin folder #1143

Merged
merged 5 commits into from
Sep 19, 2024
Merged

create admin folder #1143

merged 5 commits into from
Sep 19, 2024

Conversation

fvankrieken
Copy link
Contributor

@fvankrieken fvankrieken commented Sep 19, 2024

Bunch of little things

  • docker and python folders moved into admin/run_environment
  • python folder removed (reqs and constraints moved up into run_environment
  • docker publish scripts tweaked to run from root of project
  • ops folder created within admin - scripts that are run for specific operations. Some of these are run frequently - compile python requirements, clean build artifacts, etc. Some won't be -> create/setup dev bucket

Some of the commits are useful, mainly for specific code changes, but more than anything I would just look at the repo checked out to this branch and see what you think.

docker publish job working
compile python packages job working (and pr created)
clean build artifacts job working
qa deploy working

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.76%. Comparing base (4374792) to head (bd99ea2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1143      +/-   ##
==========================================
+ Coverage   66.25%   66.76%   +0.50%     
==========================================
  Files         106      105       -1     
  Lines        5372     5331      -41     
  Branches      799      791       -8     
==========================================
  Hits         3559     3559              
+ Misses       1686     1645      -41     
  Partials      127      127              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fvankrieken fvankrieken force-pushed the fvk-env-management branch 5 times, most recently from 644b684 to 53b6833 Compare September 19, 2024 19:22
@fvankrieken fvankrieken changed the title create admin/run_environment folder create admin folder Sep 19, 2024
@fvankrieken fvankrieken marked this pull request as ready for review September 19, 2024 19:33
@sf-dcp
Copy link
Contributor

sf-dcp commented Sep 19, 2024

may I suggest a small readme file or updated wiki page to have a short description of ops and run environment folders?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to keep it in bash? Sorry if I missed this being discussed during the meeting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we decided on the couple things left in this folder. They're all sort of "build utils" or something along those lines - this one maybe a little more in-between given that it's a final setup that runs before a build.

I think we just leave them for now

@fvankrieken
Copy link
Contributor Author

may I suggest a small readme file or updated wiki page to have a short description of ops and run environment folders?

If this gets merged I'll update https://github.com/NYCPlanning/data-engineering/wiki/Repository-Structure

Copy link
Contributor

@alexrichey alexrichey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like a definite improvement!

@fvankrieken
Copy link
Contributor Author

Updated both repository structure and docker image management wiki pages

@fvankrieken fvankrieken merged commit 09b868d into main Sep 19, 2024
26 checks passed
@fvankrieken fvankrieken deleted the fvk-env-management branch September 19, 2024 20:32
@sf-dcp
Copy link
Contributor

sf-dcp commented Sep 19, 2024

ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants