cleanup tests

NYCPlanning · Aug 21, 2024 · 7ade2c2 · 7ade2c2
1 parent 72b1dca
commit 7ade2c2
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/app/components/AdminDropdown/BoroughDropdown.test.tsx b/app/components/AdminDropdown/BoroughDropdown.test.tsx
@@ -2,6 +2,7 @@ import { Borough, createBorough } from "~/gen";
 import { BoroughDropdown } from "./BoroughDropdown";
 import { render, screen } from "@testing-library/react";
 import { userEvent } from "@testing-library/user-event";
+import { act } from "react";
 
 describe("BoroughDropdown", () => {
   let boroughs: Array<Borough> = [];
@@ -33,7 +34,7 @@ describe("BoroughDropdown", () => {
       />,
     );
 
-    await userEvent.selectOptions(screen.getByRole("combobox"), "");
+    await act(() => userEvent.selectOptions(screen.getByRole("combobox"), ""));
     expect(updateSearchParams).toHaveBeenCalledWith({
       districtType: "cd",
     });
@@ -49,7 +50,9 @@ describe("BoroughDropdown", () => {
       />,
     );
 
-    await userEvent.selectOptions(screen.getByRole("combobox"), firstBoroughId);
+    await act(() =>
+      userEvent.selectOptions(screen.getByRole("combobox"), firstBoroughId),
+    );
     expect(updateSearchParams).toHaveBeenCalledWith({
       districtType: "cd",
       boroughId: firstBoroughId,

diff --git a/app/components/AdminDropdown/index.test.tsx b/app/components/AdminDropdown/index.test.tsx
@@ -51,7 +51,7 @@ describe("AdminDropdown", () => {
     expect(testSelect?.selected).toBe(true);
   });
 
-  it("should call function when form label is clicked", () => {
+  it("should call function when form label is clicked", async () => {
     const onFormLabelClick = vi.fn();
 
     render(
@@ -65,7 +65,7 @@ describe("AdminDropdown", () => {
       </AdminDropdown>,
     );
 
-    fireEvent.click(screen.getByText("Test Boundary"));
+    await act(() => fireEvent.click(screen.getByText("Test Boundary")));
     expect(onFormLabelClick).toHaveBeenCalled();
   });
 

diff --git a/app/components/MobilePanelResizeBar.test.tsx b/app/components/MobilePanelResizeBar.test.tsx
@@ -1,7 +1,7 @@
 import { fireEvent, render, screen } from "@testing-library/react";
 import { MobilePanelResizeBar } from "./MobilePanelResizeBar";
 
-describe("MobilePanelSizeControl", () => {
+describe("MobilePanelResizeBar", () => {
   it("should have be clickable to expand", async () => {
     const isExpanded = false;
     const isExpandedToggle = vi.fn();