Update GetPrice.php - Add if statement #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, we don't receive any prices from Business Central on Category Pages in Magento. We do receive the price on product pages, but they are not listed on category pages. - We only show prices for logged in users. - When we add the new if statement it shows correctly. https://i.imgur.com/PKBRuDm.png We are not sure this fix is 100% correct, but for us it works now. Can you please review? Thanks,
Improved statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, we don't receive any prices from Business Central on Category Pages in Magento. We do receive the price on product pages, but they are not listed on category pages.
We only show prices for logged in users.
When we add the new if statement it shows correctly. https://i.imgur.com/PKBRuDm.png
I am aware that it probably won't reach the
return '<div class="commerce365-price-placeholder"></div>';anymore.We are not sure this fix is 100% correct, but for us it works now. Can you please review?
Thanks,