Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to pull NIM profiles from GCS cache #93

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pwschuurman
Copy link
Contributor

Add support to pull NIM profiles from GCS cache

@pwschuurman pwschuurman force-pushed the gcs-url-extract-cache branch from 952eafc to 21b70b5 Compare October 1, 2024 17:22
@pwschuurman pwschuurman marked this pull request as ready for review October 1, 2024 17:33
@@ -184,17 +229,17 @@ resource "helm_release" "my_nim" {

set {
name = "csi.volumeAttributes.bucketName"
value = google_storage_bucket.ngc_gcs_cache.name
value = "ngc-gcs-cache-5f0f6937-fad0-1df7-025e-a912ebf61647"
Copy link
Collaborator

@supertetelman supertetelman Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we mean for this to be a static value? Is there anything significant about this specific bucket?

if [ -n "${NGC_BUNDLE_URL:-}" ]; then
# Create a sub-directory, as tar tries to modify the parent folder permissions
export CACHE_PATH="$NIM_CACHE_PATH/cache"
mkdir "$CACHE_PATH"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be mkdir -p?

@supertetelman
Copy link
Collaborator

Would you be able to sign one of your commits prior to accepting this PR?

https://github.com/NVIDIA/nim-deploy/blob/main/CONTRIBUTING.MD#signing-your-work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants