Add NUMA node id to device plugin response #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rthallisey, please take a look |
Closed
rthallisey
reviewed
Jan 17, 2024
| log.Println("Could not get numa node id for device ", info.Name()) | ||
| return nil | ||
| } | ||
| if numaID != nil { |
There was a problem hiding this comment.
How does the topology handler deal with numaID being -1 (NotSupported)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds tests to previously created by @silenceper PR #76.
The main idea behind the improvement is to add NUMA node id of GPU card to
*pluginapi.Device. This information can be used by TopologyManager of kubelet to allocate GPU devices along with other devices on the same NUMA node, such as a another GPU card or set or CPU.More info about