Add a MIG example #182
Open
Add a MIG example #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuan Chen <[email protected]> Create a new example for MIG Signed-off-by: Yuan Chen <[email protected]> Update comment Signed-off-by: Yuan Chen <[email protected]>
klueska
reviewed
Oct 28, 2024
Comment on lines
+25
to
+27
| constraints: | ||
| - requests: [] | ||
| matchAttribute: "gpu.nvidia.com/parentUUID" |
There was a problem hiding this comment.
There is no need for this with just a single MIG device request -- this pulls together the different requests and ensures the allocations come from the same underlying GPU
klueska
reviewed
Oct 28, 2024
| args: ["nvidia-smi -L; trap 'exit 0' TERM; sleep 9999 & wait"] | ||
| resources: | ||
| claims: | ||
| - name: mig-ts-gpu |
There was a problem hiding this comment.
I wouldn't use the name *-ts-* here unless you put an explicit timeSlicing config on the request.
klueska
reviewed
Oct 28, 2024
Comment on lines
+46
to
+48
| resourceClaims: | ||
| - name: mig-ts-gpu | ||
| resourceClaimTemplateName: mig-devices |
There was a problem hiding this comment.
Can we move this below the list of containers
klueska
reviewed
Oct 28, 2024
| kind: ResourceClaimTemplate | ||
| metadata: | ||
| namespace: gpu-test-mig | ||
| name: mig-devices |
There was a problem hiding this comment.
Suggested change
| name: mig-devices | |
| name: mig-device |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new MIG example
gpu-test-mig.yamlwith the newapiVersion: resource.k8s.io/v1alpha3to the demo/quickstart folder.Validated on an A100 machine with the following MIG configuration.