Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copy edits and removal of error message in Deutsch's algorithm #2445

Merged
merged 15 commits into from
Dec 17, 2024
Merged

copy edits and removal of error message in Deutsch's algorithm #2445

merged 15 commits into from
Dec 17, 2024

Conversation

mmvandieren
Copy link
Contributor

Description

a few copy edits made, additional explanations added. also removal of an error message as the output of code.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 3, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

schweitzpgi
schweitzpgi reviewed Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

docs/sphinx/applications/python/deutschs_algorithm.ipynb Outdated Show resolved Hide resolved
@mmvandieren @schweitzpgi
Update docs/sphinx/applications/python/deutschs_algorithm.ipynb
493e2bb 
Co-authored-by: Eric Schweitz <[email protected]>
Signed-off-by: Monica VanDieren <[email protected]>
@schweitzpgi
Copy link
Collaborator

@mmvandieren It looks like the initial commit doesn't have the sign-off (DCO) message.

@mmvandieren
Copy link
Contributor Author

@mmvandieren It looks like the initial commit doesn't have the sign-off (DCO) message.
Sorry. Here it is

Signed-off-by: Monica VanDieren [email protected]
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

@bettinaheim bettinaheim added the documentation Improvements or additions to documentation label Dec 11, 2024
@bettinaheim bettinaheim added this to the release 0.9.1 milestone Dec 11, 2024
@bettinaheim
Copy link
Collaborator

bettinaheim commented Dec 11, 2024 •
edited
Loading

@mmvandieren Can you please create a commit with the following commit message:

DCO Remediation Commit for Monica VanDieren <[email protected]>

I, Monica VanDieren <[email protected]>, hereby add my Signed-off-by to this commit: ab2cb59ee0daee5c17aea6a80df3b8b5d468a14c
I, Monica VanDieren <[email protected]>, hereby add my Signed-off-by to this commit: c2d03110bed58bc711bde948731340d9bfa25f74

Signed-off-by: Monica VanDieren <[email protected]>

See also https://github.com/NVIDIA/cuda-quantum/pull/2445/checks?check_run_id=34157611619

mmvandieren and others added 2 commits December 11, 2024 09:37
@mmvandieren
copy edit to deutschs_algorithm.ipynb and sign-off added
0404dc4 
DCO Remediation Commit for Monica VanDieren <[email protected]>

I, Monica VanDieren <[email protected]>, hereby add my Signed-off-by to this commit: ab2cb59
I, Monica VanDieren <[email protected]>, hereby add my Signed-off-by to this commit: c2d0311

Signed-off-by: Monica VanDieren <[email protected]>
@schweitzpgi
Merge branch 'main' into edits-to-Deutsch
6b59d82
@schweitzpgi schweitzpgi enabled auto-merge (squash) December 11, 2024 15:45
@schweitzpgi schweitzpgi disabled auto-merge December 11, 2024 15:45
@schweitzpgi schweitzpgi enabled auto-merge (squash) December 11, 2024 15:46
@bettinaheim bettinaheim disabled auto-merge December 11, 2024 16:09
@bettinaheim
Copy link
Collaborator

bettinaheim commented Dec 11, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@schweitzpgi schweitzpgi enabled auto-merge (squash) December 11, 2024 17:57
@schweitzpgi
Copy link
Collaborator

schweitzpgi commented Dec 11, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@schweitzpgi
Copy link
Collaborator

schweitzpgi commented Dec 11, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@schweitzpgi schweitzpgi disabled auto-merge December 12, 2024 00:41
@schweitzpgi schweitzpgi enabled auto-merge (squash) December 12, 2024 20:45
@schweitzpgi
Copy link
Collaborator

schweitzpgi commented Dec 12, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@bettinaheim
Copy link
Collaborator

bettinaheim commented Dec 16, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@bettinaheim bettinaheim added the no release notes Don't list this PR in the release notes label Dec 16, 2024
@bettinaheim
Copy link
Collaborator

bettinaheim commented Dec 17, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@bettinaheim
Copy link
Collaborator

bettinaheim commented Dec 17, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@schweitzpgi schweitzpgi merged commit d40cb5b into NVIDIA:main Dec 17, 2024
211 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 17, 2024
@cuda-quantum-bot
Cleaning up docs preview for PR #2445.
b16f660
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Dec 17, 2024
@cuda-quantum-bot
Docs preview for PR #2445.
b3e8096
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schweitzpgi schweitzpgi schweitzpgi approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation no release notes Don't list this PR in the release notes
Projects
None yet
Milestone
release 0.9.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mmvandieren @schweitzpgi @bettinaheim