Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kernel_builder] Use quake.reset with a veq argument. #1912

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

schweitzpgi
Copy link
Collaborator

@schweitzpgi schweitzpgi commented Jul 10, 2024

Simplify the kernel_builder to use both qubit and veq forms of the reset op. Add a pattern to expand measurements that also expands resets.

Requires #1910 to be merged first.

Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jul 10, 2024
@schweitzpgi schweitzpgi force-pushed the ch-kernel.builder.reset branch from a3a130c to 02ac2f2 Compare July 12, 2024 23:26
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jul 13, 2024
@schweitzpgi schweitzpgi force-pushed the ch-kernel.builder.reset branch from 02ac2f2 to c33b8ab Compare July 16, 2024 15:29
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jul 16, 2024
Copy link
Collaborator

@amccaskey amccaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice simplification

Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@schweitzpgi schweitzpgi enabled auto-merge (squash) July 17, 2024 16:52
Simplify the kernel_builder to use both qubit and veq forms of the reset
op. Add a pattern to expand measurements that also expands resets.

Requires NVIDIA#1910 to be merged first.
@schweitzpgi schweitzpgi force-pushed the ch-kernel.builder.reset branch from 892fd9c to d023086 Compare July 17, 2024 17:25
@schweitzpgi schweitzpgi merged commit 27e0c73 into NVIDIA:main Jul 17, 2024
125 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2024
@schweitzpgi schweitzpgi deleted the ch-kernel.builder.reset branch July 17, 2024 21:28
@bettinaheim bettinaheim added the no release notes Don't list this PR in the release notes label Jul 29, 2024
@bettinaheim bettinaheim added this to the release 0.8.0 milestone Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no release notes Don't list this PR in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants