Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the options data class to program #237

Merged
merged 73 commits into from
Jan 19, 2025
Merged

Add the options data class to program #237

merged 73 commits into from
Jan 19, 2025

Conversation

ksimpson-work
Copy link
Contributor

@ksimpson-work ksimpson-work commented Nov 13, 2024 •
edited
Loading

close #221

Add the options class to Program.

This comes with a few side effects, namely: There are some modifications to the tests, and the LinkerOptions class now accepts None for arch (using the current device as a default), for consistency between the program options and linker options

@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Nov 13, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ksimpson-work ksimpson-work mentioned this pull request Nov 13, 2024
Closed
@ksimpson-work ksimpson-work marked this pull request as ready for review November 13, 2024 00:39
warsawnv
warsawnv reviewed Nov 13, 2024
View reviewed changes
Copy link

@warsawnv warsawnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some drive-by observations. Feel free to ignore!

cuda_core/cuda/core/experimental/_program.py Outdated Show resolved Hide resolved
cuda_core/cuda/core/experimental/_program.py Outdated Show resolved Hide resolved
cuda_core/cuda/core/experimental/_program.py Outdated Show resolved Hide resolved
cuda_core/cuda/core/experimental/_program.py Outdated Show resolved Hide resolved
@leofang leofang added P1 Medium priority - Should do cuda.core Everything related to the cuda.core module enhancement Any code-related improvements labels Nov 14, 2024
@leofang leofang added this to the cuda.core beta 2 milestone Nov 14, 2024
@leofang
Copy link
Member

leofang commented Nov 14, 2024

Just some drive-by observations. Feel free to ignore!

Thanks, Berry 🙏 We welcome feedbacks and won't ignore anyone!

@leofang
Copy link
Member

leofang commented Nov 14, 2024

Another TODO: Let's also update the code samples and show the best practice!

@warsawnv
Copy link

Another TODO: Let's also update the code samples and show the best practice!

Is there a way to add these as doctests so that the code samples must always be kept in working order?

@ksimpson-work
Copy link
Contributor Author

@warsawnv Totally. I'm actively working on getting github actions working, and the examples are invoked as part of the testsuite.

@ksimpson-work
Copy link
Contributor Author

/ok to test

@ksimpson-work
Copy link
Contributor Author

Other than the default values for some program options, I believe all the comments and issues have been addressed. Thanks for your feedback @warsawnv and @leofang

leofang
leofang requested changes Nov 26, 2024
View reviewed changes
cuda_core/cuda/core/experimental/_program.py Outdated Show resolved Hide resolved
cuda_core/cuda/core/experimental/_program.py Outdated Show resolved Hide resolved
cuda_core/cuda/core/experimental/_program.py Outdated Show resolved Hide resolved
cuda_core/cuda/core/experimental/_program.py Outdated Show resolved Hide resolved
cuda_core/cuda/core/experimental/_program.py Outdated Show resolved Hide resolved
cuda_core/cuda/core/experimental/_program.py Show resolved Hide resolved
cuda_core/cuda/core/experimental/_program.py Show resolved Hide resolved
cuda_core/cuda/core/experimental/_program.py Outdated Show resolved Hide resolved
cuda_core/cuda/core/experimental/_utils.py Outdated Show resolved Hide resolved
cuda_core/cuda/core/experimental/_program.py Show resolved Hide resolved
@ksimpson-work
Copy link
Contributor Author

Very good point

@leofang leofang mentioned this pull request Nov 27, 2024
Merged
@ksimpson-work ksimpson-work force-pushed the ksimpson/add_program_options branch from 03128c8 to 6d789cb Compare November 27, 2024 19:20
@leofang leofang removed the P1 Medium priority - Should do label Nov 28, 2024
@ksimpson-work
Copy link
Contributor Author

/ok to test

@ksimpson-work
Copy link
Contributor Author

/ok to test

@ksimpson-work ksimpson-work requested a review from leofang January 14, 2025 00:21
@ksimpson-work
Copy link
Contributor Author

/ok to test

@ksimpson-work
Copy link
Contributor Author

/ok to test

@ksimpson-work
Copy link
Contributor Author

/ok to test

@leofang
Copy link
Member

leofang commented Jan 16, 2025

/ok to test

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@leofang
Copy link
Member

leofang commented Jan 19, 2025

pre-commit.ci autofix

@leofang leofang force-pushed the ksimpson/add_program_options branch from 0d52c25 to 9ef4821 Compare January 19, 2025 04:45
@leofang
Copy link
Member

leofang commented Jan 19, 2025

/ok to test

leofang
leofang approved these changes Jan 19, 2025
View reviewed changes
Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Very thorough changes, thanks Keenan!

@leofang leofang enabled auto-merge January 19, 2025 05:01
@leofang leofang merged commit d62c7fa into main Jan 19, 2025
69 checks passed
@leofang leofang deleted the ksimpson/add_program_options branch January 19, 2025 05:19
@github-actions GitHub Actions
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warsawnv warsawnv warsawnv left review comments

@leofang leofang leofang approved these changes

@vzhurba01 vzhurba01 Awaiting requested review from vzhurba01

Assignees

@ksimpson-work ksimpson-work

Labels
breaking Breaking changes are introduced cuda.core Everything related to the cuda.core module enhancement Any code-related improvements P0 High priority - Must do!
Projects
None yet
Milestone
cuda.core beta 3
Development

Successfully merging this pull request may close these issues.

Program.compile() options parameter is not handled properly
3 participants
@ksimpson-work @leofang @warsawnv