Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include pyx/pyd files in the wheel's root cuda directory #225

Closed
wants to merge 1 commit into from

Conversation

thomasjpfan
Copy link

With this change the .pxd and friends files are included in the wheel under "cuda" as well as "cuda/bindings"

You can test with: python -m pip wheel -vvv . and unzip the wheel.

CC @leofang

Copy link

copy-pr-bot bot commented Nov 8, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang leofang marked this pull request as draft November 8, 2024 02:15
@leofang
Copy link
Member

leofang commented Nov 8, 2024

@thomasjpfan Thanks a lot for looking into this for us! I did try this simple change yesterday, but it did not work back then. Most likely, it's because I did not clean up build/ when I tried it, and it got all messed up:
https://setuptools.pypa.io/en/latest/userguide/miscellaneous.html#caching-and-troubleshooting

Unfortunately, I hate to say this but while this repository is "source open," the current (NVIDIA, non-permissive) license prohibits us from accepting external contributions 😞 I will have to raise a new PR and check it in under my name. Sorry about the awkward situation.

@leofang
Copy link
Member

leofang commented Nov 8, 2024

but it did not work back then. Most likely, it's because I did not clean up build/ when I tried it, and it got all messed up

Unfortunately regardless of cleaning up build/ or not it always works with this change and I can't reproduce anymore, so it could be possible when I tried different combinations of [tools.setuptools] and [tools.setuptools.package.find] I simply missed this one.

But, another local observation that a standalone bindings module being installed does get picked up in at least one of our public wheels (#226), so it is an issue that we need to fix.

@leofang
Copy link
Member

leofang commented Nov 8, 2024

This doesn't work on Windows (which I believe might be what Vlad had observed when preparing the fix internally). Looking into it...

@leofang
Copy link
Member

leofang commented Nov 9, 2024

Superseded by #230/#231.

@leofang leofang closed this Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants