Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scripts] Remove fixed seed for adding noise #11401

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

anteju
Copy link
Collaborator

@anteju anteju commented Nov 26, 2024

What does this PR do ?

This PR removes a fixed value of seed when adding noise examples.
With a fixed seed, each worker will select the same noise file.
If required, fixed seed can be set from CLI.

Collection: Scripts

Changelog

  • Changed default seed from 42 to None

Usage

If necessary, the original behavior can be reproduced using

python add_noisy.py ... --seed 42

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

KunalDhawan
KunalDhawan previously approved these changes Nov 26, 2024
Copy link
Collaborator

@KunalDhawan KunalDhawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:

************* Module add_noise
scripts/dataset_processing/add_noise.py:42:0: C0116: Missing function or method docstring (missing-function-docstring)
scripts/dataset_processing/add_noise.py:46:0: C0116: Missing function or method docstring (missing-function-docstring)
scripts/dataset_processing/add_noise.py:76:0: C0116: Missing function or method docstring (missing-function-docstring)
scripts/dataset_processing/add_noise.py:114:0: C0116: Missing function or method docstring (missing-function-docstring)
scripts/dataset_processing/add_noise.py:131:0: C0116: Missing function or method docstring (missing-function-docstring)
scripts/dataset_processing/add_noise.py:28:0: W0611: Unused import random (unused-import)

-----------------------------------
Your code has been rated at 9.37/10

Thank you for improving NeMo's documentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants