-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partially lower fusion to optimize deserialization performance. #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
!build |
Need to update for new fusion executor dispatch system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes the deserialization time by only running the analyze step in
GpuLower
. We skip all the passes while retaining the necessary information to run a kernel. Deserialization is estimated to be ~75% faster than recompilingGpuLower
completely.After kernel compilation, we only need the information in
GpuLower::KernelSummary
to create a newExecutorEntry
at runtime. Thekir::Allocate
nodes are generated directly without the rest of the lowering process.Our approach for creating
kir::Allocate
nodes is based on theExpressionEvaluator
. During serialization, we store a set of base IterDomains and a series of operations to create the TensorViews domains. The
kir::Allocatenodes are not inserted into the
kir::Kernel` because they are only used to calculate the size of buffers at kernel runtime.TODOs:
ExpressionSerializer
andExpressionBuilder
buildsTensorView
andkir::Allocate
nodes for global intermediate buffers and dynamic shared memory.KernelSummary
, which is stored inFusionExecutor
.KernelSummary
LoadStoreOp
RNGOps
andTMA
kir nodes