Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary NVF_API #3562

Merged
merged 1 commit into from
Dec 11, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions csrc/kernel_ir.h
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ class Predicate final : public Val {

std::string toString(int indent_size = 0) const override;

NVF_API std::string toInlineString(int indent_size = 0) const override;
std::string toInlineString(int indent_size = 0) const override;

PredicateType predicate_type() const {
return ptype_;
Expand Down Expand Up @@ -148,7 +148,7 @@ class Predicate final : public Val {
Val* value_ = nullptr;
};

class NVF_API TensorIndex final : public Val {
class TensorIndex final : public Val {
public:
TensorIndex(
IrBuilderPasskey,
Expand Down Expand Up @@ -252,7 +252,7 @@ class Asm final : public Expr {
//! is required as an intermediate within a kernel. The extent is the expression
//! of the size of the buffer that is generated from the TensorView that
//! describes the output of an operation.
class NVF_API Allocate final : public Expr {
class Allocate final : public Expr {
public:
using Expr::Expr;

Expand Down Expand Up @@ -385,7 +385,7 @@ class NVF_API Allocate final : public Expr {
//
// TODO(kir): change name to SyncThreads as we could have other barriers.
//
class NVF_API BlockSync final : public Expr {
class BlockSync final : public Expr {
public:
using Expr::Expr;

Expand All @@ -408,7 +408,7 @@ class NVF_API BlockSync final : public Expr {

// Synchronize all blocks in device, implies cooperative group launch is
// required.
class NVF_API GridSync final : public Expr {
class GridSync final : public Expr {
public:
using Expr::Expr;

Expand Down Expand Up @@ -436,7 +436,7 @@ class NVF_API GridSync final : public Expr {
};

// PTX: fence.proxy.async
class NVF_API FenceAsyncProxy final : public Expr {
class FenceAsyncProxy final : public Expr {
public:
using Expr::Expr;

Expand All @@ -453,7 +453,7 @@ class NVF_API FenceAsyncProxy final : public Expr {
};

// PTX: wgmma.fence.sync.aligned
class NVF_API WgMmaFence final : public Expr {
class WgMmaFence final : public Expr {
public:
using Expr::Expr;

Expand All @@ -469,7 +469,7 @@ class NVF_API WgMmaFence final : public Expr {
std::string toInlineString(int indent_size = 0) const override;
};

class NVF_API MBarrierInit final : public Expr {
class MBarrierInit final : public Expr {
public:
using Expr::Expr;
explicit MBarrierInit(
Expand All @@ -495,7 +495,7 @@ class NVF_API MBarrierInit final : public Expr {
}
};

class NVF_API MBarrierInvalidate final : public Expr {
class MBarrierInvalidate final : public Expr {
public:
using Expr::Expr;
explicit MBarrierInvalidate(IrBuilderPasskey passkey, Val* mbarrier);
Expand All @@ -514,7 +514,7 @@ class NVF_API MBarrierInvalidate final : public Expr {
}
};

class NVF_API MBarrierArrive final : public Expr {
class MBarrierArrive final : public Expr {
public:
using Expr::Expr;
explicit MBarrierArrive(IrBuilderPasskey passkey, Val* state, Val* mbarrier);
Expand Down Expand Up @@ -544,7 +544,7 @@ class NVF_API MBarrierArrive final : public Expr {
// This is usually used to specify the number of bytes that will be
// transferred for cp.async and cp.async.bulk, so that future mbarrier.wait
// can wait for the completion of the transfer.
class NVF_API MBarrierArriveExpectTx final : public Expr {
class MBarrierArriveExpectTx final : public Expr {
public:
using Expr::Expr;
explicit MBarrierArriveExpectTx(
Expand Down Expand Up @@ -578,7 +578,7 @@ class NVF_API MBarrierArriveExpectTx final : public Expr {
}
};

class NVF_API MBarrierWait final : public Expr {
class MBarrierWait final : public Expr {
public:
using Expr::Expr;
explicit MBarrierWait(IrBuilderPasskey passkey, Val* mbarrier, Val* state);
Expand All @@ -601,7 +601,7 @@ class NVF_API MBarrierWait final : public Expr {
}
};

class NVF_API MBarrierWaitParity final : public Expr {
class MBarrierWaitParity final : public Expr {
public:
using Expr::Expr;
explicit MBarrierWaitParity(
Expand Down Expand Up @@ -796,7 +796,7 @@ class UpdateMagicZero final : public Expr {
//!
//! TODO(kir): this is not a real expression
//!
class NVF_API IfThenElse final : public Expr {
class IfThenElse final : public Expr {
public:
using Expr::Expr;

Expand Down Expand Up @@ -915,7 +915,7 @@ class GridReduction final : public ReductionOp {
}
};

class NVF_API GroupedGridReduction final : public GroupedReductionOp {
class GroupedGridReduction final : public GroupedReductionOp {
public:
using GroupedReductionOp::GroupedReductionOp;

Expand Down Expand Up @@ -1006,7 +1006,7 @@ class NVF_API GroupedGridReduction final : public GroupedReductionOp {
//!
//! This node provides KernelExecutor the information it needs to allocate the
//! broadcast and sync buffers.
class NVF_API GridBroadcast final : public Expr {
class GridBroadcast final : public Expr {
public:
using Expr::Expr;

Expand Down Expand Up @@ -1117,7 +1117,7 @@ class GridWelford final : public Expr {
}
};

class NVF_API GroupedGridWelford final : public GroupedWelfordOp {
class GroupedGridWelford final : public GroupedWelfordOp {
public:
using GroupedWelfordOp::GroupedWelfordOp;

Expand Down Expand Up @@ -1211,7 +1211,7 @@ class NVF_API GroupedGridWelford final : public GroupedWelfordOp {

//! Represents a WelfordOp with the division by count is hoisted out
//! of an innermost loop
class NVF_API VectorizedWelfordOp final : public WelfordOp {
class VectorizedWelfordOp final : public WelfordOp {
public:
using WelfordOp::WelfordOp;

Expand Down
Loading