Move StMatrix and TMA Store swizzle schedule functions to mma_utils #3552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdspring1
force-pushed
the
hopper_matmul_stsm_refactor
branch
from
f34b697 to
20a4b5e
Compare
rdspring1
changed the base branch from
main
to
hopper_matmul_stsm_refactor_pt1
rdspring1
changed the title
rdspring1
changed the title
rdspring1
changed the title
rdspring1
added a commit
that referenced
this pull request
Dec 10, 2024
This PR contains the actual code changes from #3552. 1. Fix `hardCodedIndexGenerationForStMatrixSwizzle` for stmatrix (16, 8). The lane column is always `lane_id / 16` not `lane_id / stsm_n_tile`. 2. Fix `tmaSwizzleSharedMemory` by ensuring box inner dimension is evenly divisible by swizzle size. 3. Clean `scheduleTMAStoreForMmaOutput` and `scheduleStMatrixForMmaOutput` by remove unnecessary scheduling and correcting `num_ids_to_skip`. 4. Replace `mma_macro_to_str_map` with `macroToString` function.
…tmul_stsm_refactor
jacobhinkle
approved these changes
Dec 10, 2024
|
!test |
zasdfgbnm
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is stack on #3553.
Changes
analyzeSwizzleSharedMemory,tmaSwizzleSharedMemory,scheduleStMatrixForMmaOutput, andscheduleTMAStoreForMmaOutputtomma_utils.swizzleSharedMemoryfrom hopper matmul scheduler.mma_utils.