-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Resize scheduler #3425
Draft
naoyam
wants to merge
116
commits into
main
Choose a base branch
from
resize_scheduler
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[WIP] Resize scheduler #3425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
naoyam
commented
Nov 16, 2024
•
edited
Loading
edited
- Enable the IdModel loop option (Initial resize scheduler #3556 (comment))
This was referenced Dec 4, 2024
naoyam
added a commit
that referenced
this pull request
Dec 4, 2024
Currently we check all loop groups, no matter if they correspond to loop IDs. For loop promotion, we only need to consider loop domains when checking if the full loop promotion analysis can be skipped. This refinement was necessary when playing with scheduling approaches for resize, although it is not currently necessary in #3425. I think this is generally better than the current method.
naoyam
added a commit
that referenced
this pull request
Dec 6, 2024
Extracted from #3425 A simple scheduling utility that replays a single transform expr on the loop domain of a given tensor. It is conceptually similar to the existing transform propagator, but this interface can also replay a transform expr not just as a forward expr but also as a backward expr. The existing `scheduler_tools::scheduleLoopDomainsLike` can also be used to propagate loop domains across tensors, but I encountered with a couple of issues due to the resize mapping [issue](#3455). This `scheduleLoopDomainsBy` gives more explicit control to set loop domains with resize ops.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.