Validate allocation sizes and strides more widely. #3375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!test |
wujingyue
force-pushed
the
wjy/validate
branch
from
536fd2a to
21c6e2e
Compare
|
!test |
wujingyue
force-pushed
the
wjy/validate
branch
from
47b8ea7 to
2453f1b
Compare
wujingyue
changed the title
wujingyue
changed the title
wujingyue
commented
Nov 13, 2024
| @@ -209,65 +209,66 @@ class BackwardTraverseFromLogicalToAlloc { | |||
| }; | |||
|
|
|||
| void validateAllocationSizesAndStrides( | |||
| const std::vector<IterDomain*>& alloc_dom_no_reductions, | |||
| const std::vector<IterDomain*>& alloc_dom, | |||
There was a problem hiding this comment.
This is mostly a clean-up. I may have fixed a few bugs and/or hardened the validation, but I don't quite remember what was broken exactly...
wujingyue
commented
Nov 13, 2024
| } else { | ||
| metadata->alloc_size = metadata->logical_size; | ||
| metadata->alloc_stride = metadata->logical_stride; | ||
| // TODO: validateAllocationSizesAndStrides |
There was a problem hiding this comment.
This is now done unconditionally in inferAndValidateAllocationSizesAndStrides.
wujingyue
commented
Nov 13, 2024
| metadata->alloc_stride = metadata->logical_stride; | ||
| // TODO: validateAllocationSizesAndStrides | ||
| } | ||
| auto [sizes, strides] = |
There was a problem hiding this comment.
There's a micro optimization to reuse input.sizes() and input.strides(). I didn't do that because I chose to optimize for simplicity for now. Let me know if there's a compelling reason otherwise.
|
!test |
jjsjann123
reviewed
Nov 13, 2024
Currently, GetMetaData::evaluate validates allocation sizes and strides only when the TV has allocation that's different from logical. With this PR, it will validate allocation even when it's the same as logical. This extra validation captured many bugs including #3386 and #3194. These bugs are either fixed in this PR or in follow-ups. Fixes #3194.
wujingyue
force-pushed
the
wjy/validate
branch
from
546a429 to
d13a63e
Compare
|
!test |
wujingyue
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, GetMetaData::evaluate validates allocation sizes and strides
only when the TV has allocation that's different from logical. With this
PR, it will validate allocation even when it's the same as logical.
This extra validation captured many bugs including #3386 and #3194.
These bugs are either fixed in this PR or in follow-ups.
Prepares for #3282