Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure expression simplification is enabled in proveLinearAndGetStride #3345

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

jacobhinkle
Copy link
Collaborator

When debugging the matmul scheduler, I noticed that we hit an error when generating Hopper MMA when we use NVFUSER_DISABLE=expr_simplify. This PR makes that possible again. Note that the option is disabled only within proveLinearAndGetStride so it has no direct effect on index expressions, which is what we want to look at when using that option.

When debugging the matmul scheduler, I noticed that we hit an error when
generating Hopper MMA when we use `NVFUSER_DISABLE=expr_simplify`. This
PR makes that possible again. Note that the option is disabled only
within `proveLinearAndGetStride` so it has no direct effect on index
expressions, which is what we want to look at when using that option.
@jacobhinkle jacobhinkle requested a review from zasdfgbnm November 5, 2024 14:55
@jacobhinkle
Copy link
Collaborator Author

!test

@jacobhinkle
Copy link
Collaborator Author

I think the distributed test failures are benign.

@jacobhinkle jacobhinkle merged commit 0261d6b into main Nov 7, 2024
45 of 47 checks passed
@jacobhinkle jacobhinkle deleted the enable_simplification_for_prove_linear branch November 7, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants