Prefer simpler vals in replace sizes #3344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!test --diff-bench |
|
!build |
jacobhinkle
approved these changes
Nov 5, 2024
| // Within these three classes, we find the IterDomain with the smallest | ||
| // name(). | ||
| // Within these three classes, we find the IterDomain with the | ||
| // smallest name(). For case 3, we also prefer the IterDomain with |
There was a problem hiding this comment.
I guess we could also do this for Case 1 just for readability, but it shouldn't affect the compiled kernel so not important..
There was a problem hiding this comment.
Yeah, I didn't do that just because get_number_of_defs may not be cheap.
|
!test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while working on #3309 that
i0is replaced withceilDiv(i0, 1). While it isn't incorrect, it would make generated code look simpler ifceilDiv(i0, 1)is replaced withi0.This PR just changes representative iter domains used for replacing extents. In addition to the existing priority rules, the iter domain with the simplest extent is preferred as the representative ID of a given ID group. The simplicity of extents is just defined based on the number of expressions defining the extent val. So, for example, an iter domain with extent of
i0should be used as the representative ID instead of iter domains with extentceilDiv(i0, 1).There should be no logic change.