Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make prepareInputs private. #3340

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Make prepareInputs private. #3340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions csrc/runtime/fusion_executor_cache.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,12 +140,6 @@ class FusionExecutorCache {
std::optional<PrimDataType> forced_index_type = std::nullopt,
std::optional<int8_t> selected_device = std::nullopt);

//! Converts inputs from IValue to KernelArgumentHolder, also handles cache
//! lookup
KernelArgumentHolder prepareInputs(
const at::ArrayRef<c10::IValue>& inputs,
std::optional<int8_t> selected_device = std::nullopt);

//! query if there's a kernel ready to go for given inputs
NVF_API bool isCompiled(
const at::ArrayRef<c10::IValue>& inputs,
Expand Down Expand Up @@ -241,6 +235,12 @@ class FusionExecutorCache {
void deserialize(const serde::FusionExecutorCache* buffer, int64_t fusion_id);

private:
//! Converts inputs from IValue to KernelArgumentHolder, also handles cache
//! lookup
KernelArgumentHolder prepareInputs(
const at::ArrayRef<c10::IValue>& inputs,
std::optional<int8_t> selected_device = std::nullopt);

//! evict cached short cut entry in `code_to_fe_lookup_` as well as cached
//! entry in `FusionExecutor`
void evictCache(size_t cache_id);
Expand Down
Loading