Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean 2dInnerReductionHeuristic #3331

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

liqiangxl
Copy link
Collaborator

@liqiangxl liqiangxl commented Nov 3, 2024

Following #3330
Removed paras and computations related to 3D inner reduction.

@liqiangxl
Copy link
Collaborator Author

!build

@liqiangxl liqiangxl marked this pull request as ready for review November 6, 2024 13:35
@liqiangxl liqiangxl requested a review from jjsjann123 November 6, 2024 13:35
Copy link
Collaborator

@jjsjann123 jjsjann123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp for mechanical changes.
nitpick: let's do a code diff to verify that this one isn't introducing any behavior change.

@liqiangxl liqiangxl changed the base branch from llu/2d_inner_reduction_heuristics to main November 8, 2024 14:20
@liqiangxl
Copy link
Collaborator Author

!build !test --diff --diff-bench

@liqiangxl liqiangxl force-pushed the llu/clean_2d_inner_reduction_heuristics branch from c339d72 to c7e107c Compare November 8, 2024 14:34
@liqiangxl
Copy link
Collaborator Author

!build !test --diff --diff-bench

@liqiangxl
Copy link
Collaborator Author

!test --diff --diff-bench

@liqiangxl
Copy link
Collaborator Author

@jjsjann123 code diffs are known issues where order of output is changed.

@liqiangxl liqiangxl merged commit 8bd9984 into main Nov 8, 2024
50 of 53 checks passed
@liqiangxl liqiangxl deleted the llu/clean_2d_inner_reduction_heuristics branch November 8, 2024 18:59
liqiangxl added a commit that referenced this pull request Nov 11, 2024
Following #3331
refactor 2d inner reduction heuristics, prepare for further heuristics tunning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants