Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean uses of unique_ptr. #3326

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Clean uses of unique_ptr. #3326

merged 1 commit into from
Nov 6, 2024

Conversation

wujingyue
Copy link
Collaborator

No description provided.

@wujingyue
Copy link
Collaborator Author

!build

@wujingyue wujingyue requested a review from jjsjann123 November 1, 2024 23:09
@wujingyue
Copy link
Collaborator Author

!test

jjsjann123
jjsjann123 approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@jjsjann123 jjsjann123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for code cleaning.

@wujingyue wujingyue merged commit 9cc07d7 into main Nov 6, 2024
47 checks passed
@wujingyue wujingyue deleted the wjy/unique branch November 6, 2024 19:18
wujingyue added a commit that referenced this pull request Nov 7, 2024
@wujingyue
Redo #3326.
77a8db7 
The change was accidentally reverted in
#3349.
wujingyue added a commit that referenced this pull request Nov 7, 2024
@wujingyue
Redo #3326. (#3370)
e072c92 
The change was accidentally reverted in
#3349.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjsjann123 jjsjann123 jjsjann123 approved these changes

Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wujingyue @jjsjann123