You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liqiangxl
changed the title
Llu/ps unroll inner outer
add knobs control inner dim unroll and outer dim unroll in pointwise scheduler redo pr-3275 to check code changes
Nov 1, 2024
(1) code diff in nvfuser-ci/jit_codegen_diff_bench_20_10/10 and nvfuser-ci/jit_codegen_diff_bench_20_9/10 are due to we deleted the split when unroll factor is 1. Removing one loop, leads to different compute at position and different expression order. This change is not a blocker since it only happens when the input can't be vectorized. I didn't check the performance since it is rare and we have a following PR reivising heuristics.
(2) code diffs in nvfuser-ci/jit_codegen_diff_20_5/7 , nvfuser-ci/jit_codegen_diff_20_6/7 , and nvfuser-ci/jit_codegen_diff_20_7/7 are RNGTest, also because of the input size can't be vectorized and split of unroll = 1 is skipped.
(3) code diffs in ci/jit_codegen_diff_20_7/7 also has a DynamicTransformIssue418_CUDA where output order is switched. can't reproduce in local run.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
liqiangxl
changed the title
redo #3275 to check code changes.