Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix is_clonable in test_issue_3292 #3319

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Fix is_clonable in test_issue_3292 #3319

merged 1 commit into from
Oct 31, 2024

Conversation

rdspring1
Copy link
Collaborator

This PR adds ceilDiv to serde, which enables is_clonable in test_issue_3292.

@rdspring1 rdspring1 requested a review from jacobhinkle October 31, 2024 00:39
@rdspring1
Copy link
Collaborator Author

!build

@rdspring1 rdspring1 added the serde serde = serialization + deserialization label Oct 31, 2024
jacobhinkle
jacobhinkle approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@jacobhinkle jacobhinkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rdspring1 rdspring1 merged commit a4b549a into main Oct 31, 2024
37 of 38 checks passed
@rdspring1 rdspring1 deleted the cpp_to_python_ceildiv branch October 31, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobhinkle jacobhinkle jacobhinkle approved these changes

Assignees
No one assigned
Labels
serde serde = serialization + deserialization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rdspring1 @jacobhinkle